Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: add PanelCallbackHandler #27039

Closed
wants to merge 19 commits into from

Conversation

ahuang11
Copy link

@ahuang11 ahuang11 commented Oct 2, 2024

Description:

Migrates https://panel.holoviz.org/reference/chat/PanelCallbackHandler.html over to langchain-community.

Dependencies: panel
Twitter: IAteAnDrew1

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 4:18am

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 2, 2024
@dosubot dosubot bot added the community Related to langchain-community label Oct 2, 2024
@ahuang11
Copy link
Author

Can you take a look at this PR @vbarda? Thanks!

@langcarl
Copy link

langcarl bot commented Nov 4, 2024

Thank you for the PR. This PR is marked Needs Support and has not yet received the 5 upvotes required by maintainers for review. It has been open for at least 25 days. Per the LangChain review process, this PR will be closed in 5 days if it does not reach the required threshold.

The Needs Support status is intended to prioritize review time on features that have demonstrated community support. If you feel this status was assigned in error or need more time to gather the required upvotes, please ping @ccurme and @efriis.

@langcarl langcarl bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 4, 2024
@ahuang11
Copy link
Author

ahuang11 commented Nov 7, 2024

@ccurme can I have some more time to gather upvotes? Thanks!

@efriis
Copy link
Member

efriis commented Nov 7, 2024

hey! lots of CI issues, and I don't think this makes sense to duplicate the code here (in general we're more encouraging of externally-packaged/documented callback handlers like you have already!)

if I added a section to the callbacks list on "external callbacks" that included a link to your linked docs page would that work?

@ahuang11
Copy link
Author

ahuang11 commented Nov 7, 2024

lots of CI issues

I can fix those; seems like it's just long lines

I don't think this makes sense to duplicate the code

We are actually planning to deprecate this in Panel holoviz/panel#7470

I think we'd prefer the callback handler to live in the langchain community.

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Nov 11, 2024
@ahuang11
Copy link
Author

ahuang11 commented Dec 3, 2024

Can I have this reviewed? Thanks!

@efriis
Copy link
Member

efriis commented Dec 4, 2024

oops sorry for the delay! we're actually not taking on new callback integrations (see this doc ) - mostly because of maintenance overhead if people make PRs against a callback like this, which tend to be difficult to review, as callbacks tend to rely much more on the external integration.

Given it's already in our docs, we're happy to accept updates to the docs pointing the integration to how it's best to install! Let me know if that makes sense

If it works for you, you're also welcome to publish a separate langchain-panel package that includes the code such that it doesn't live in either main package

@efriis efriis closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:XL This PR changes 500-999 lines, ignoring generated files. stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants