-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
community: add PanelCallbackHandler #27039
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Can you take a look at this PR @vbarda? Thanks! |
Thank you for the PR. This PR is marked The |
@ccurme can I have some more time to gather upvotes? Thanks! |
hey! lots of CI issues, and I don't think this makes sense to duplicate the code here (in general we're more encouraging of externally-packaged/documented callback handlers like you have already!) if I added a section to the callbacks list on "external callbacks" that included a link to your linked docs page would that work? |
I can fix those; seems like it's just long lines
We are actually planning to deprecate this in Panel holoviz/panel#7470 I think we'd prefer the callback handler to live in the langchain community. |
Can I have this reviewed? Thanks! |
oops sorry for the delay! we're actually not taking on new callback integrations (see this doc ) - mostly because of maintenance overhead if people make PRs against a callback like this, which tend to be difficult to review, as callbacks tend to rely much more on the external integration. Given it's already in our docs, we're happy to accept updates to the docs pointing the integration to how it's best to install! Let me know if that makes sense If it works for you, you're also welcome to publish a separate langchain-panel package that includes the code such that it doesn't live in either main package |
Description:
Migrates https://panel.holoviz.org/reference/chat/PanelCallbackHandler.html over to langchain-community.
Dependencies:
panel
Twitter: IAteAnDrew1